feat!: Update ReadLinesAsync to return IAsyncEnumerable<string> #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the ReadLinesAsync method to improve efficiency and memory usage when processing large files. BREAKING CHANGE: The return type of ReadLinesAsync has been changed from Task<string[]> to IAsyncEnumerable<string>. Consumers of ReadLinesAsync must now use an async enumeration pattern (e.g., C# 8's `await foreach`) instead of awaiting a single array. This allows lines to be processed one by one as they are read from the source, avoiding the need to load all lines into memory simultaneously. Test updates: * Related unit and integration tests have been updated to use the new `IAsyncEnumerable<string>` consumption pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the ReadLinesAsync method to improve efficiency and memory usage when processing large files.
BREAKING CHANGE: The return type of ReadLinesAsync has been changed from Task<string[]> to IAsyncEnumerable.
Consumers of ReadLinesAsync must now use an async enumeration pattern (e.g., C# 8's
await foreach) instead of awaiting a single array. This allows lines to be processed one by one as they are read from the source, avoiding the need to load all lines into memory simultaneously.Test updates:
IAsyncEnumerable<string>consumption pattern.Fixes #1339